Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 263213007: New analysis_server snapshot and completion.dart in analysis_services. (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

New analysis_server snapshot and completion.dart in analysis_services. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4927 lines, -562 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java View 59 chunks +101 lines, -198 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/Filter.java View 1 chunk +94 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/Ident.java View 1 chunk +51 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/completion/CompletionProposalImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitMinorRefactoringsComputer.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitReferencesComputer.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 6 chunks +21 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainAnalysisServer.java View 7 chunks +108 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 4 chunks +10 lines, -5 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/GuavaSemanticProcessor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated/service_computers.dart View 22 chunks +457 lines, -235 lines 0 comments Download
M pkg/analysis_server/lib/src/generated/service_interfaces.dart View 4 chunks +291 lines, -109 lines 0 comments Download
M pkg/analysis_services/lib/src/generated/change.dart View 2 chunks +2 lines, -1 line 0 comments Download
A pkg/analysis_services/lib/src/generated/completion.dart View 1 chunk +3770 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/generated/proposal.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/generated/stubs.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/generated/util.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 7 months ago (2014-05-06 18:19:12 UTC) #1
Brian Wilkerson
LGTM
6 years, 7 months ago (2014-05-06 18:42:12 UTC) #2
scheglov
6 years, 7 months ago (2014-05-06 18:55:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698