Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 263213004: [dart:html] tests for attached/detached callback (Closed)

Created:
6 years, 7 months ago by Jennifer Messerly
Modified:
6 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, blois
Visibility:
Public.

Description

[dart:html] tests for attached/detached callback Did not change pkg:polymer yet, as it doesn't seem like it depends on Dart 1.4 SDK. BUG= https://code.google.com/p/dart/issues/detail?id=17385 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=35823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -27 lines) Patch
M tests/html/custom/entered_left_view_test.dart View 10 chunks +105 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
Tests for this feature, now that dart2js and dartium side have landed. BUG=https://code.google.com/p/dart/issues/detail?id=17385
6 years, 7 months ago (2014-05-06 01:35:50 UTC) #1
Jacob
lgtm
6 years, 7 months ago (2014-05-06 20:00:19 UTC) #2
Jennifer Messerly
6 years, 7 months ago (2014-05-06 20:01:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698