Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 26318004: fix dart2js warnings in polymer_expressions pkg (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix dart2js warnings in polymer_expressions pkg BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=28627

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M pkg/polymer_expressions/example/person.dart View 1 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/polymer_expressions/lib/eval.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer_expressions/lib/filter.dart View 1 1 chunk +6 lines, -6 lines 1 comment Download
M pkg/polymer_expressions/lib/src/globals.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer_expressions/test/globals_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-11 23:14:33 UTC) #1
Siggi Cherem (dart-lang)
lgtm, thank you!
7 years, 2 months ago (2013-10-11 23:22:59 UTC) #2
Siggi Cherem (dart-lang)
btw - could we add a analyzer-clean test for polymer_expressions?
7 years, 2 months ago (2013-10-11 23:23:22 UTC) #3
Jennifer Messerly
PTAL, additional cleanups. I tried to turn on @static-clean as you requested, but am blocked ...
7 years, 2 months ago (2013-10-14 19:46:21 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/26318004/diff/6001/pkg/polymer_expressions/lib/filter.dart File pkg/polymer_expressions/lib/filter.dart (right): https://codereview.chromium.org/26318004/diff/6001/pkg/polymer_expressions/lib/filter.dart#newcode16 pkg/polymer_expressions/lib/filter.dart:16: class _InverseTransformer<V, T> implements Transformer<V, T> { note: this ...
7 years, 2 months ago (2013-10-14 19:48:43 UTC) #5
Siggi Cherem (dart-lang)
lgtm
7 years, 2 months ago (2013-10-14 21:19:36 UTC) #6
Jennifer Messerly
7 years, 2 months ago (2013-10-15 02:54:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r28627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698