Issue 263103003: Remove warnings from dart2js test-suite.

Issue 263103003: Remove warnings from dart2js test-suite. (Closed)

Created:
6 years, 7 months ago by karlklose

Modified:
6 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove warnings from dart2js test-suite. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35738

Patch Set 2 : Remove debug code. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -121 lines)			Patch
M	sdk/lib/mirrors/mirrors.dart	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js/bad_output_io_test.dart	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/begin_end_token_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/codegen_helper.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/dart_backend_test.dart	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/dart_printer_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/deferred_not_in_main_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/find_my_name_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/members_test.dart	View		3 chunks	+11 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/memory_source_file_helper.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/metadata_test.dart	View		6 chunks	+9 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/mirror_helper_test.dart	View		3 chunks	+13 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/mirror_helper_unique_minification_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/mirror_tree_shaking_test.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/mirrors_used_test.dart	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js/parser_test.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/resolution_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/source_mapping_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View		5 chunks	+28 lines, -50 lines	0 comments	Download
M	tests/compiler/dart2js/type_variable_occurrence_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/unparser2_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/263103003/diff/1/tests/compiler/dart2js/resolver_test.dart File tests/compiler/dart2js/resolver_test.dart (right): https://codereview.chromium.org/263103003/diff/1/tests/compiler/dart2js/resolver_test.dart#newcode619 tests/compiler/dart2js/resolver_test.dart:619: print(element.runtimeType); Remove debug code.

6 years, 7 months ago (2014-05-05 11:27:09 UTC) #2

karlklose

6 years, 7 months ago (2014-05-05 11:47:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35738 (presubmit successful).

Expand Messages | Collapse Messages