Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 263083010: Remove unreachable code from the code generator. (Closed)

Created:
6 years, 7 months ago by Florian Schneider
Modified:
6 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove unreachable code from the code generator. The case of constant array bounds check can only occur for the overflow case. Otherwise, the compiler eliminates those checks already before code generation. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
Srdjan, do you remember which test was failing at the point? The code seems to ...
6 years, 7 months ago (2014-05-05 16:02:38 UTC) #1
srdjan
LGTM Unfortunately I did not write in the comments which tests were failing, and of ...
6 years, 7 months ago (2014-05-05 16:06:41 UTC) #2
Florian Schneider
6 years, 7 months ago (2014-05-06 09:23:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698