Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 26308004: Update idb tests to verify correct number behavior. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update idb tests to verify correct number behavior. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28881

Patch Set 1 : #

Patch Set 2 : retry #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M tests/html/indexeddb_1_test.dart View 1 2 6 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
Dartium change: https://codereview.chromium.org/27767003/ Appengine has been acting up with this upload. let me know if ...
7 years, 2 months ago (2013-10-17 21:21:38 UTC) #1
Emily Fortuna
(update on this, you can see the first version of this CL in Patch 1, ...
7 years, 2 months ago (2013-10-17 21:24:53 UTC) #2
blois
https://codereview.chromium.org/26308004/diff/22001/tests/html/indexeddb_1_test.dart File tests/html/indexeddb_1_test.dart (right): https://codereview.chromium.org/26308004/diff/22001/tests/html/indexeddb_1_test.dart#newcode130 tests/html/indexeddb_1_test.dart:130: equals("{time: 4503599627370492}"), null, STORE_NAME, VERSION, true)); Can you add ...
7 years, 2 months ago (2013-10-17 22:16:15 UTC) #3
Emily Fortuna
ptal
7 years, 2 months ago (2013-10-17 23:51:01 UTC) #4
blois
lgtm
7 years, 2 months ago (2013-10-18 00:23:19 UTC) #5
Emily Fortuna
7 years, 2 months ago (2013-10-18 21:42:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r28881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698