Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 26293005: Modifications to TypeVariableMirror implementation to accommodate expected hoisting of methods from… (Closed)

Created:
7 years, 2 months ago by gbracha
Modified:
7 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Modifications to TypeVariableMirror implementation to accommodate expected hoisting of methods from ClassMirror to TypeMirror. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
gbracha
7 years, 2 months ago (2013-10-10 22:49:22 UTC) #1
rmacnak
LGTM
7 years, 2 months ago (2013-10-11 02:05:05 UTC) #2
gbracha
7 years, 2 months ago (2013-10-11 02:15:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698