Issue 262883005: Simplify flow graph building for instantiator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262883005: Simplify flow graph building for instantiator. (Closed)

Created:
6 years, 7 months ago by Florian Schneider

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify flow graph building for instantiator. The instantiator is always loaded from a local variable which is determined in the parser. There is no need to create an AST a fresh ValueGraphVisitor for it since the flow graph builder can just emit a load-local. This also makes it clear that the instantiator is not an arbitrary expresssion. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35699

Patch Set 1 #

Patch Set 2 : more small simplfications #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -25 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	5 chunks	+13 lines, -19 lines	0 comments	Download
M	runtime/vm/parser.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Please take a look at #2. I removed some more code: BuildInstantiator is always called ...

6 years, 7 months ago (2014-05-02 17:47:22 UTC) #3

Florian Schneider

6 years, 7 months ago (2014-05-02 17:58:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r35699 (presubmit successful).

Expand Messages | Collapse Messages