Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262823012: Various vmservice/observatory fixes: (Closed)

Created:
6 years, 7 months ago by turnidge
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Various vmservice/observatory fixes: - get rid of double lines on vm view page - show eval errors in monospace font - make eval highlight color consistent - fix broken navbar on script view page - show list of all libs for an isolate - use two-column view to save space on isolate view page - give the dart:nativewrappers library a name R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35745

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+904 lines, -691 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 7 chunks +109 lines, -73 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 77 chunks +204 lines, -207 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 7 chunks +109 lines, -73 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 77 chunks +223 lines, -188 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/css/shared.css View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_box.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 3 1 chunk +15 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 3 1 chunk +83 lines, -64 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_ref.html View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/css/shared.css View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/eval_box.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 chunk +15 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 2 1 chunk +83 lines, -64 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_ref.html View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_view.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_ref.dart View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 3 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/issue14236_test.dart View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 7 months ago (2014-05-02 20:35:45 UTC) #1
Cutch
lgtm with changes we added offline
6 years, 7 months ago (2014-05-02 21:26:44 UTC) #2
turnidge
6 years, 7 months ago (2014-05-05 16:55:12 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r35745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698