Issue 262823009: Convert BinadryDoubleOp to MathUnaryInstr double-square if both inputs are the same. Uses less regi…

Issue 262823009: Convert BinadryDoubleOp to MathUnaryInstr double-square if both inputs are the same. Uses less regi… (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Convert BinadryDoubleOp to MathUnaryInstr double-square if both inputs are the same. Uses less registers. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35714

Patch Set 6 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -41 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	4 chunks	+22 lines, -8 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	2 chunks	+12 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4 5	3 chunks	+31 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4 5	3 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	2 chunks	+15 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4 5	3 chunks	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	2 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with minor comment https://codereview.chromium.org/262823009/diff/70001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/262823009/diff/70001/runtime/vm/intermediate_language_ia32.cc#newcode4555 runtime/vm/intermediate_language_ia32.cc:4555: (kind() == MathUnaryInstr::kDoubleSquare)); white space ...

6 years, 7 months ago (2014-05-02 21:24:48 UTC) #2

srdjan

https://codereview.chromium.org/262823009/diff/70001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/262823009/diff/70001/runtime/vm/intermediate_language_ia32.cc#newcode4555 runtime/vm/intermediate_language_ia32.cc:4555: (kind() == MathUnaryInstr::kDoubleSquare)); On 2014/05/02 21:24:48, Cutch wrote: > ...

6 years, 7 months ago (2014-05-02 22:05:21 UTC) #3

srdjan

6 years, 7 months ago (2014-05-02 22:38:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r35714 (presubmit successful).

Expand Messages | Collapse Messages