Formatter code transform bit-flip support.

Formatter code transform bit-flip support.

(Lest a user only want whitespace formatting.)

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28331

[Brian Wilkerson, 2013-10-07 21:37:28]

LGTM

https://chromiumcodereview.appspot.com/26280005/diff/1/pkg/analyzer_experimen...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://chromiumcodereview.appspot.com/26280005/diff/1/pkg/analyzer_experimen...
pkg/analyzer_experimental/test/services/formatter_test.dart:795:
expectStmtFormatsTo('if (true) print("true!"); else print("false!");',
I expect you'll want to test the "transforms: true" case as well. You might
consider passing in three parameters to the expect method: the source to be
formatted, the result to expect if transforms is false, and an optional third
parameter that is the result to expect if transforms is true.

[pquitslund, 2013-10-07 22:33:44]

https://chromiumcodereview.appspot.com/26280005/diff/1/pkg/analyzer_experimen...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://chromiumcodereview.appspot.com/26280005/diff/1/pkg/analyzer_experimen...
pkg/analyzer_experimental/test/services/formatter_test.dart:795:
expectStmtFormatsTo('if (true) print("true!"); else print("false!");',
On 2013/10/07 21:37:29, Brian Wilkerson wrote:
> I expect you'll want to test the "transforms: true" case as well. You might
> consider passing in three parameters to the expect method: the source to be
> formatted, the result to expect if transforms is false, and an optional third
> parameter that is the result to expect if transforms is true.

The expect above actually does that.  I like your idea of compressing this into
one call though.  I'll look at it.  Thanks!

[pquitslund, 2013-10-07 22:34:10]

Committed patchset #1 manually as r28331 (presubmit successful).