Issue 262793006: Uses double load/store on arm64, enables tests.

Issue 262793006: Uses double load/store on arm64, enables tests. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Uses double load/store on arm64, enables tests. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35705

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+341 lines, -54 lines)			Patch
M	runtime/vm/assembler_arm64.h	View		3 chunks	+27 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	8 chunks	+96 lines, -7 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		2 chunks	+25 lines, -2 lines	0 comments	Download
M	runtime/vm/guard_field_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		11 chunks	+171 lines, -19 lines	0 comments	Download
M	runtime/vm/stack_frame_arm64.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		6 chunks	+17 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/262793006/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/262793006/diff/1/runtime/vm/assembler_arm64.cc#newcode634 runtime/vm/assembler_arm64.cc:634: ASSERT(base != TMP2); I would move this assert ...

6 years, 7 months ago (2014-05-02 19:59:15 UTC) #2

zra

Thanks! https://codereview.chromium.org/262793006/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/262793006/diff/1/runtime/vm/assembler_arm64.cc#newcode634 runtime/vm/assembler_arm64.cc:634: ASSERT(base != TMP2); On 2014/05/02 19:59:16, regis wrote: ...

6 years, 7 months ago (2014-05-02 20:16:11 UTC) #3

zra

6 years, 7 months ago (2014-05-02 20:16:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35705 (presubmit successful).

Expand Messages | Collapse Messages