Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 26279008: Reapply KeyEvent improvements. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply KeyEvent improvements. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=28370

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+777 lines, -178 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 25 chunks +267 lines, -68 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 15 chunks +162 lines, -48 lines 0 comments Download
M tests/html/keyboard_event_test.dart View 1 chunk +70 lines, -8 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +55 lines, -0 lines 0 comments Download
M tools/dom/src/KeyCode.dart View 1 chunk +55 lines, -0 lines 0 comments Download
M tools/dom/src/KeyName.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/KeyboardEventStream.dart View 7 chunks +21 lines, -44 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 2 chunks +112 lines, -4 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 3 chunks +26 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +1 line, -1 line 1 comment Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
Let's try this again! https://codereview.chromium.org/26279008/diff/11001/tools/dom/templates/html/dartium/html_dartium.darttemplate File tools/dom/templates/html/dartium/html_dartium.darttemplate (left): https://codereview.chromium.org/26279008/diff/11001/tools/dom/templates/html/dartium/html_dartium.darttemplate#oldcode53 tools/dom/templates/html/dartium/html_dartium.darttemplate:53: export 'dart:math' show Rectangle, RectangleBase, ...
7 years, 2 months ago (2013-10-08 17:57:51 UTC) #1
Emily Fortuna
patchset 1 is the previous version of the CL I checked in. Patchset 2 are ...
7 years, 2 months ago (2013-10-08 17:58:48 UTC) #2
sra1
lgtm
7 years, 2 months ago (2013-10-08 18:04:08 UTC) #3
Emily Fortuna
7 years, 2 months ago (2013-10-08 18:10:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698