Issue 26277003: - Fix usability of coverage tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26277003: - Fix usability of coverage tool. (Closed)

Created:
7 years, 2 months ago by Ivan Posva

Modified:
7 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix usability of coverage tool. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28328

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -21 lines)			Patch
		tools/full-coverage.dart	View	1	7 chunks	+34 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/26277003/diff/1/tools/full-coverage.dart File tools/full-coverage.dart (right): https://chromiumcodereview.appspot.com/26277003/diff/1/tools/full-coverage.dart#newcode32 tools/full-coverage.dart:32: final HTTP_PREFIX = "http://"; Should these be 'static ...

7 years, 2 months ago (2013-10-07 21:56:34 UTC) #2

Ivan Posva

https://codereview.chromium.org/26277003/diff/1/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/26277003/diff/1/tools/full-coverage.dart#newcode32 tools/full-coverage.dart:32: final HTTP_PREFIX = "http://"; On 2013/10/07 21:56:34, siva wrote: ...

7 years, 2 months ago (2013-10-07 22:07:12 UTC) #3

Ivan Posva

7 years, 2 months ago (2013-10-07 22:07:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r28328 (presubmit successful).

Expand Messages | Collapse Messages

Issue 26277003: - Fix usability of coverage tool. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages