Issue 262763005: Add mobile safari simulator support in the testing scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262763005: Add mobile safari simulator support in the testing scripts (Closed)

Created:
6 years, 7 months ago by ricow1

Modified:
6 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add mobile safari simulator support in the testing scripts R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35626

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -3 lines)			Patch
M	tools/test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tools/testing/dart/browser_controller.dart	View	2 chunks	+50 lines, -0 lines	0 comments	Download
M	tools/testing/dart/runtime_configuration.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/dart/utils.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/262763005/diff/1/tools/test.dart File tools/test.dart (right): https://codereview.chromium.org/262763005/diff/1/tools/test.dart#newcode168 tools/test.dart:168: // use one browser. Additionally, you can not ...

6 years, 7 months ago (2014-05-01 11:09:28 UTC) #2

ricow1

6 years, 7 months ago (2014-05-01 11:32:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35626 (presubmit successful).

Expand Messages | Collapse Messages