Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 26263004: Handle a null dependencies map in lockfile. (Closed)

Created:
7 years, 2 months ago by Bob Nystrom
Modified:
7 years, 2 months ago
Reviewers:
nweiz, Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle a null dependencies map in lockfile. BUG=https://code.google.com/p/dart/issues/detail?id=14001 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=28618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M sdk/lib/_internal/pub/lib/src/lock_file.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lock_file_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
.containsKey("key") isn't the same thing as ["key"] != null when the key is present but ...
7 years, 2 months ago (2013-10-14 21:32:02 UTC) #1
Alan Knight
lgtm
7 years, 2 months ago (2013-10-14 22:29:28 UTC) #2
Bob Nystrom
7 years, 2 months ago (2013-10-14 22:54:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698