Fix snapshot generation to ensure that the snapshot does not contain

Fix snapshot generation to ensure that the snapshot does not contain
the instance size of internal VM defined classes. These classes have
non word fields and the instance_size_in_words will not be correct
across different platforms.

This fixes the Dartium for Android build issue (snapshot is generated
on the host which is 64 bit and loaded later into a 32 bit process
on Android).

R=iposva@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28391

[zra, 2013-10-08 21:58:40]

Works on ARM Android Dartium and lgtm.

Thanks for fixing this!

[Ivan Posva, 2013-10-08 22:33:49]

LGTMwC

-Ivan

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
runtime/vm/raw_object_snapshot.cc:68:
cls.set_next_field_offset_in_words(reader->ReadIntptrValue());
This should be in sync with the instance size field.

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
runtime/vm/raw_object_snapshot.cc:113:
writer->WriteIntptrValue(ptr()->next_field_offset_in_words_);
ditto

[siva, 2013-10-08 22:50:39]

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
runtime/vm/raw_object_snapshot.cc:68:
cls.set_next_field_offset_in_words(reader->ReadIntptrValue());
On 2013/10/08 22:33:49, Ivan Posva wrote:
> This should be in sync with the instance size field.

Done.

https://chromiumcodereview.appspot.com/26247007/diff/13001/runtime/vm/raw_obj...
runtime/vm/raw_object_snapshot.cc:113:
writer->WriteIntptrValue(ptr()->next_field_offset_in_words_);
On 2013/10/08 22:33:49, Ivan Posva wrote:
> ditto

Done.

[siva, 2013-10-08 23:10:43]

Committed patchset #5 manually as r28391 (presubmit successful).