Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 26247006: Fix KeyEvent (factory) constructor in Dartium. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix KeyEvent (factory) constructor in Dartium. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
I had refactored the dart2js version, but left out this change in the dartium version.
7 years, 2 months ago (2013-10-08 19:32:28 UTC) #1
vsm
lgtm
7 years, 2 months ago (2013-10-08 19:33:31 UTC) #2
Emily Fortuna
7 years, 2 months ago (2013-10-08 19:43:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698