Issue 262433003: Add writeHeaders argument to HttpResponse::detachSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262433003: Add writeHeaders argument to HttpResponse::detachSocket. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen

Modified:
6 years, 7 months ago

Reviewers:
nweiz, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add writeHeaders argument to HttpResponse::detachSocket. BUG=https://code.google.com/p/dart/issues/detail?id=18390 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35571

Patch Set 2 : fix comment. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
M	sdk/lib/io/http.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download
M	tests/standalone/io/http_detach_socket_test.dart	View		2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/262433003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/262433003/diff/1/sdk/lib/io/http_impl.dart#newcode538 sdk/lib/io/http_impl.dart:538: // Immidate we wrote the headers. "Imitate having ...

6 years, 7 months ago (2014-04-29 19:59:09 UTC) #2

Anders Johnsen

https://codereview.chromium.org/262433003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/262433003/diff/1/sdk/lib/io/http_impl.dart#newcode538 sdk/lib/io/http_impl.dart:538: // Immidate we wrote the headers. On 2014/04/29 19:59:09, ...

6 years, 7 months ago (2014-04-30 12:35:49 UTC) #3

Anders Johnsen

Committed patchset #2 manually as r35571 (presubmit successful).

6 years, 7 months ago (2014-04-30 12:38:00 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 262433003: Add writeHeaders argument to HttpResponse::detachSocket. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix comment. #

Messages