Issue 262333007: Adds arm64 double arithmetic instructions.

Issue 262333007: Adds arm64 double arithmetic instructions. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds arm64 double arithmetic instructions. Also adds: - double comparison instructions, - conditional increment instruction, - double <-> int conversion instructions, - IL instructions that use these, - NoSuchMethod call stub, - and bug fixes. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35830

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+711 lines, -98 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1 2	4 chunks	+68 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1 2	3 chunks	+220 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 2	8 chunks	+33 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 2	5 chunks	+58 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		4 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2	8 chunks	+118 lines, -16 lines	0 comments	Download
M	runtime/vm/simulator_arm64.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2	6 chunks	+130 lines, -35 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		2 chunks	+65 lines, -1 line	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM except for a discrepancy with the spec. https://codereview.chromium.org/262333007/diff/20001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/262333007/diff/20001/runtime/vm/simulator_arm64.cc#newcode1969 runtime/vm/simulator_arm64.cc:1969: int32_t ...

6 years, 7 months ago (2014-05-06 20:01:12 UTC) #2

zra

https://codereview.chromium.org/262333007/diff/20001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/262333007/diff/20001/runtime/vm/simulator_arm64.cc#newcode1969 runtime/vm/simulator_arm64.cc:1969: int32_t result32 = rm_val32; On 2014/05/06 20:01:12, regis wrote: ...

6 years, 7 months ago (2014-05-06 20:50:23 UTC) #3

zra

6 years, 7 months ago (2014-05-06 20:50:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35830 (presubmit successful).

Expand Messages | Collapse Messages