Support type promotion in dart2js.

Support type promotion in dart2js.

BUG=http://dartbug.com/13806
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28654

[Lasse Reichstein Nielsen, 2013-10-10 10:49:15]

Just more test suggestions.

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
File tests/language/type_promotion_functions_test.dart (right):

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
tests/language/type_promotion_functions_test.dart:14: typedef A FuncDynToA(x);
Document the subtype/specificity relation between the types here, not just
spread around the tests.

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
File tests/language/type_promotion_parameter_test.dart (right):

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
tests/language/type_promotion_parameter_test.dart:160: }
Testing inside && branches?
   if (a is D 
       && a.a == "" 
       && a.b == ""  /// 42: static type warning
       && a.c == ""  /// 43: static type warning
       && a.d == "")
    // test for D again.
and similar tests for C and B.

Also perhaps have it advance the type *inside* the and;
  a is B 
  ..
  && a.b == ""
  && a.c == ""  // warning
  ...
  && a is C
  ...
  && a.c == ""  // not warning.

[Johnni Winther, 2013-10-10 15:36:02]

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
File tests/language/type_promotion_functions_test.dart (right):

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
tests/language/type_promotion_functions_test.dart:14: typedef A FuncDynToA(x);
On 2013/10/10 10:49:16, Lasse Reichstein Nielsen wrote:
> Document the subtype/specificity relation between the types here, not just
> spread around the tests.

More specific document. (Subtype is not used)

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
File tests/language/type_promotion_parameter_test.dart (right):

https://codereview.chromium.org/26232003/diff/6001/tests/language/type_promot...
tests/language/type_promotion_parameter_test.dart:160: }
On 2013/10/10 10:49:16, Lasse Reichstein Nielsen wrote:
> Testing inside && branches?
>    if (a is D 
>        && a.a == "" 
>        && a.b == ""  /// 42: static type warning
>        && a.c == ""  /// 43: static type warning
>        && a.d == "")
>     // test for D again.
> and similar tests for C and B.
> 
> Also perhaps have it advance the type *inside* the and;
>   a is B 
>   ..
>   && a.b == ""
>   && a.c == ""  // warning
>   ...
>   && a is C
>   ...
>   && a.c == ""  // not warning.
>  

Done.

[karlklose, 2013-10-15 11:56:16]

LGTM.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1905: /// The
nodes for which variable access and mutation must be registed in order
'registed' -> 'registered'.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1906: /// to
determine when variable types are promoted.
'when the static type of variables is promoted.'

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2263:
doInPromotionScope(node.thenPart, () =>
Break line before closure.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/typechecker.dart:776: if (variable !=
null) {
Merge the ifs.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/typechecker.dart:814:
Map<VariableElement, DartType> shownForReceiver =
Share code with l. 823-830.

https://codereview.chromium.org/26232003/diff/13001/tests/compiler/dart2js/ty...
File tests/compiler/dart2js/type_promotion_test.dart (right):

https://codereview.chromium.org/26232003/diff/13001/tests/compiler/dart2js/ty...
tests/compiler/dart2js/type_promotion_test.dart:4: 
Add a comment explaining what you do here.

[Johnni Winther, 2013-10-15 15:57:00]

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1905: /// The
nodes for which variable access and mutation must be registed in order
On 2013/10/15 11:56:17, karlklose wrote:
> 'registed' -> 'registered'.

Done.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1906: /// to
determine when variable types are promoted.
On 2013/10/15 11:56:17, karlklose wrote:
> 'when the static type of variables is promoted.'

Done.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2263:
doInPromotionScope(node.thenPart, () =>
On 2013/10/15 11:56:17, karlklose wrote:
> Break line before closure.

Done.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/typechecker.dart:776: if (variable !=
null) {
On 2013/10/15 11:56:17, karlklose wrote:
> Merge the ifs.

Done.

https://codereview.chromium.org/26232003/diff/13001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/typechecker.dart:814:
Map<VariableElement, DartType> shownForReceiver =
On 2013/10/15 11:56:17, karlklose wrote:
> Share code with l. 823-830.

Done.

https://codereview.chromium.org/26232003/diff/13001/tests/compiler/dart2js/ty...
File tests/compiler/dart2js/type_promotion_test.dart (right):

https://codereview.chromium.org/26232003/diff/13001/tests/compiler/dart2js/ty...
tests/compiler/dart2js/type_promotion_test.dart:4: 
On 2013/10/15 11:56:17, karlklose wrote:
> Add a comment explaining what you do here.

Done.

[Johnni Winther, 2013-10-15 16:28:20]

Committed patchset #5 manually as r28654 (presubmit successful).