Fixed (currently harmless) bug in test_runner and implemented separate dart2js compilation cache

Fixed (currently harmless) bug in test_runner and implemented separate dart2js compilation cache

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28634

[ricow1, 2013-10-15 11:03:24]

LGTM (very good :-) )

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1226: var csp = configuration['csp'] ? '-csp'
: '';
I guess we don't need this here either

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1240: Path relative =
testPath.relativeTo(TestUtils.dartDir());
how about extracting these 3 lines into a method and using it from here and from
createOutputDirectory. Even better, these two methods share something like 90%
of their code, just extract all that into a single function

[kustermann, 2013-10-15 11:50:23]

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1226: var csp = configuration['csp'] ? '-csp'
: '';
On 2013/10/15 11:03:24, ricow1 wrote:
> I guess we don't need this here either

Well, we do, because we the *html file lives in there, and if one configuration
is with csp mode and the other one without we've got a race condition.

(but we'll be able to remove this stuff eventually as well).

https://codereview.chromium.org/26229005/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1240: Path relative =
testPath.relativeTo(TestUtils.dartDir());
On 2013/10/15 11:03:24, ricow1 wrote:
> how about extracting these 3 lines into a method and using it from here and
from
> createOutputDirectory. Even better, these two methods share something like 90%
> of their code, just extract all that into a single function

Done.

[kustermann, 2013-10-15 11:50:53]

Committed patchset #3 manually as r28634 (presubmit successful).