Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 26229004: Code formatter transform for empty constructor bodys (a la Style guide). (Closed)

Created:
7 years, 2 months ago by pquitslund
Modified:
7 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code formatter transform for empty constructor bodys (a la Style guide). From the guide: "DO terminate empty constructors with a ‘;’ and not ‘{}’." R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=28380

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -5 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 1 3 chunks +23 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 2 months ago (2013-10-08 21:09:00 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-08 21:36:23 UTC) #2
pquitslund
7 years, 2 months ago (2013-10-08 21:39:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698