standalone.deps: Change gyp generation to make "./tools/build.py runtime" work

standalone.deps: Change gyp generation to make "./tools/build.py runtime" work

R=iposva@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28929

[kustermann, 2013-10-10 16:43:23]

We've one way of building and that is './tools/build.py runtime'.

[Ivan Posva, 2013-10-11 04:22:24]

I don't think this will have the desired effect as you will end up with
unbuildable targets.

-Ivan

[kustermann, 2013-10-16 09:17:38]

I was aware of the fact that this resulted in un-buildable targets (that's why I
said './tools/build.py runtime' instead of './tools/build.py').

But I think you're right, we should use the runtime specific gyp file.

[kustermann, 2013-10-16 09:17:42]

PTAL

[ricow1, 2013-10-16 09:20:00]

LGTM, but please wait for Ivan, I think he may need to coordinate with other
people regarding their build scripts

[Ivan Posva, 2013-10-17 05:59:11]

As far as I understand this will not change the location of the build files nor
the location of the build output, so I think we should be good to go.

Thanks,
-Ivan

https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
File dart/tools/generate_projects.py (left):

https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
dart/tools/generate_projects.py:59: args += ['-I', './tools/gyp/common.gypi']
You should also be able to remove the common.gypi file and all other references
to it.

[ricow1, 2013-10-17 06:55:59]

On 2013/10/17 05:59:11, Ivan Posva wrote:
> As far as I understand this will not change the location of the build files
nor
> the location of the build output, so I think we should be good to go.
> 
It will change the location, it will place the build files directly in dart
instead of in dart/runtime, this is the dept argument we pass in



> Thanks,
> -Ivan
> 
>
https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
> File dart/tools/generate_projects.py (left):
> 
>
https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
> dart/tools/generate_projects.py:59: args += ['-I', './tools/gyp/common.gypi']
> You should also be able to remove the common.gypi file and all other
references
> to it.

[kustermann, 2013-10-17 11:03:53]

As rico said, this will put the Makefile inside dart/ -- which enables
"./tools/build.py" to work!

Please comment if that is an issue, otherwise I'll commit it tomorrow.

https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
File dart/tools/generate_projects.py (left):

https://codereview.chromium.org/26212004/diff/3002/dart/tools/generate_projec...
dart/tools/generate_projects.py:59: args += ['-I', './tools/gyp/common.gypi']
On 2013/10/17 05:59:11, Ivan Posva wrote:
> You should also be able to remove the common.gypi file and all other
references
> to it.

I wasn't sure about dartium, but I've grepped around and couldn't find any other
references.

So I'll remove it as well.

[Ivan Posva, 2013-10-18 16:47:54]

LGTM

I think we are good to go.

-Ivan

[kustermann, 2013-10-21 12:33:47]

Committed patchset #3 manually as r28929 (presubmit successful).