Issue 26203003: Make sequence-zip test not flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26203003: Make sequence-zip test not flaky. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sequence-zip test not flaky. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28302

Patch Set 2 : Address comment. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -23 lines)			Patch
	M	pkg/sequence_zip/test/stream_test.dart	View	1	2 chunks	+20 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/26203003/diff/1/pkg/sequence_zip/test/stream_test.dart File pkg/sequence_zip/test/stream_test.dart (right): https://codereview.chromium.org/26203003/diff/1/pkg/sequence_zip/test/stream_test.dart#newcode144 pkg/sequence_zip/test/stream_test.dart:144: // Transformer that puts error into controller one ...

7 years, 2 months ago (2013-10-07 08:19:31 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/26203003/diff/1/pkg/sequence_zip/test/stream_test.dart File pkg/sequence_zip/test/stream_test.dart (right): https://codereview.chromium.org/26203003/diff/1/pkg/sequence_zip/test/stream_test.dart#newcode144 pkg/sequence_zip/test/stream_test.dart:144: // Transformer that puts error into controller one of ...

7 years, 2 months ago (2013-10-07 08:27:27 UTC) #3

Lasse Reichstein Nielsen

7 years, 2 months ago (2013-10-07 08:28:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28302 (presubmit successful).

Expand Messages | Collapse Messages

Issue 26203003: Make sequence-zip test not flaky. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages