Make ObjectGraph a StackResource.

Make ObjectGraph a StackResource.

R=iposva@google.com
TBR=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35775

[Ivan Posva, 2014-05-05 17:22:38]

LGTMwC

-Ivan

https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph.h
File runtime/vm/object_graph.h (right):

https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph....
runtime/vm/object_graph.h:66: Isolate* isolate_;
Now that this class is a StackResource you should be able to access the isolate
out of the resource avoiding the duplicated field here.

[koda, 2014-05-05 19:55:13]

On 2014/05/05 17:22:38, Ivan Posva wrote:
> LGTMwC
> 
> -Ivan
> 
> https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph.h
> File runtime/vm/object_graph.h (right):
> 
>
https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph....
> runtime/vm/object_graph.h:66: Isolate* isolate_;
> Now that this class is a StackResource you should be able to access the
isolate
> out of the resource avoiding the duplicated field here.

No, StackResource only contains a BaseIsolate*, so I'd have to down-cast it
before accessing Isolate::heap and VisitObjectPointers, which seemed worse than
duplicating the field. Do you agree?

[koda, 2014-05-05 22:19:57]

On 2014/05/05 19:55:13, koda wrote:
> On 2014/05/05 17:22:38, Ivan Posva wrote:
> > LGTMwC
> > 
> > -Ivan
> > 
> >
https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph.h
> > File runtime/vm/object_graph.h (right):
> > 
> >
>
https://codereview.chromium.org/261753012/diff/60001/runtime/vm/object_graph....
> > runtime/vm/object_graph.h:66: Isolate* isolate_;
> > Now that this class is a StackResource you should be able to access the
> isolate
> > out of the resource avoiding the duplicated field here.
> 
> No, StackResource only contains a BaseIsolate*, so I'd have to down-cast it
> before accessing Isolate::heap and VisitObjectPointers, which seemed worse
than
> duplicating the field. Do you agree?

Now done, thanks to your change.

[koda, 2014-05-05 22:20:15]

Committed patchset #4 manually as r35775 (presubmit successful).