Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 26164007: Formatter method cascade indents. (Closed)

Created:
7 years, 2 months ago by pquitslund
Modified:
7 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter method cascade indents. In keeping with the current style guide suggestion: "DO use four spaces for method cascades." R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=28427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 2 months ago (2013-10-09 21:12:33 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-09 22:07:58 UTC) #2
pquitslund
7 years, 2 months ago (2013-10-09 22:34:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698