Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 26162007: Remove unittest-based wrapping from our testing scripts (Closed)

Created:
7 years, 2 months ago by kustermann
Modified:
7 years, 2 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unittest-based wrapping from our testing scripts The unittest-based wrapping of tests is completely broken and will be removed with this CL. ('none-drt' is the last configuration where we currently still do unittest-based wrapping.) BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=28501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -66 lines) Patch
M pkg/unittest/lib/test_controller.js View 1 chunk +8 lines, -3 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +33 lines, -8 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 5 chunks +7 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
We still have these small wrappers around main() to get the 'dart-calling-main'/'dart-main-done' messages -- eventually ...
7 years, 2 months ago (2013-10-10 15:27:06 UTC) #1
ricow1
LGTM
7 years, 2 months ago (2013-10-11 07:43:52 UTC) #2
kustermann
7 years, 2 months ago (2013-10-11 09:01:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698