Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 26151004: Create _RootZone and _RootSpecification. (Closed)

Created:
7 years, 2 months ago by floitsch
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create _RootZone and _RootSpecification. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=28641

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -29 lines) Patch
M sdk/lib/async/zone.dart View 1 3 chunks +106 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
Should make the root-zone more efficient. Also makes it easier to see if we forgot ...
7 years, 2 months ago (2013-10-15 11:56:32 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/26151004/diff/1/sdk/lib/async/zone.dart File sdk/lib/async/zone.dart (right): https://codereview.chromium.org/26151004/diff/1/sdk/lib/async/zone.dart#newcode747 sdk/lib/async/zone.dart:747: Map<Symbol, dynamic> copiedMap = new HashMap(); Why was ...
7 years, 2 months ago (2013-10-15 12:04:07 UTC) #2
floitsch
PTAL.
7 years, 2 months ago (2013-10-15 12:47:21 UTC) #3
Lasse Reichstein Nielsen
lgtm
7 years, 2 months ago (2013-10-15 12:48:26 UTC) #4
floitsch
https://codereview.chromium.org/26151004/diff/1/sdk/lib/async/zone.dart File sdk/lib/async/zone.dart (right): https://codereview.chromium.org/26151004/diff/1/sdk/lib/async/zone.dart#newcode747 sdk/lib/async/zone.dart:747: Map<Symbol, dynamic> copiedMap = new HashMap(); On 2013/10/15 12:04:07, ...
7 years, 2 months ago (2013-10-15 13:06:06 UTC) #5
floitsch
7 years, 2 months ago (2013-10-15 13:32:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r28641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698