Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 26135004: Adding ElementEventStream.capture (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding ElementEventStream.capture Also making Element.on[] return an ElementStream. BUG=13214 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -49 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 8 chunks +48 lines, -16 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +48 lines, -16 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 4 chunks +30 lines, -15 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +8 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-17 19:54:53 UTC) #1
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-17 20:12:32 UTC) #2
blois
7 years, 2 months ago (2013-10-17 20:19:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698