Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 261283002: Add annotated steps script for validating that the version on dev and stable is always increasing w… (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add annotated steps script for validating that the version on dev and stable is always increasing when we do new builds. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=35734

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M tools/bots/bot_utils.py View 2 chunks +10 lines, -2 lines 0 comments Download
A tools/bots/version_checker.py View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-05 09:25:57 UTC) #1
kustermann
https://codereview.chromium.org/261283002/diff/30001/tools/bots/version_checker.py File tools/bots/version_checker.py (right): https://codereview.chromium.org/261283002/diff/30001/tools/bots/version_checker.py#newcode64 tools/bots/version_checker.py:64: return False This is a bit fragile. You can ...
6 years, 7 months ago (2014-05-05 09:37:58 UTC) #2
kustermann
LGTM
6 years, 7 months ago (2014-05-05 09:42:38 UTC) #3
ricow1
6 years, 7 months ago (2014-05-05 09:43:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r35734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698