Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 26115003: Fixing dart2js size regression from CustomElement.detail (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Fixing dart2js size regression from CustomElement.detail The annotation for CustomEvent.detail was being dropped. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=28807

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-17 15:58:46 UTC) #1
sra1
lgtm
7 years, 2 months ago (2013-10-17 17:24:52 UTC) #2
blois
7 years, 2 months ago (2013-10-17 17:37:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698