Move allowTrailingOptions into ArgParser.

Move allowTrailingOptions into ArgParser.

R=brianwilkerson@google.com, jmesserly@google.com, nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35837

[Bob Nystrom, 2014-05-02 00:54:21]

This is a breaking change, but in practice, none of the packages in our repo
(except for pub) use allowTrailingOptions, so aren't affected by this. So I just
widened their constraints to accept this version of args as well as the previous
one.

[kevmoo, 2014-05-02 03:05:48]

DBC

https://codereview.chromium.org/260963007/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/pubspec.yaml#newcode13
pkg/args/pubspec.yaml:13: unittest: ">=0.9.0 <0.10.0"
While you're at it: update this to <0.11.0

[nweiz, 2014-05-05 19:52:45]

lgtm

https://codereview.chromium.org/260963007/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/1/pkg/analyzer/pubspec.yaml#ne...
pkg/analyzer/pubspec.yaml:9: args: '>=0.10.0 <0.12.0'
You should bump the build versions of any non-dev packages whose dependencies
you're changing, and CC the owners on this CL.

https://codereview.chromium.org/260963007/diff/1/pkg/args/CHANGELOG.md
File pkg/args/CHANGELOG.md (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/CHANGELOG.md#newcode5
pkg/args/CHANGELOG.md:5: trailing options.
What's with all the whitespace between the * and the text?

https://codereview.chromium.org/260963007/diff/1/pkg/args/test/trailing_optio...
File pkg/args/test/trailing_options_test.dart (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/test/trailing_optio...
pkg/args/test/trailing_options_test.dart:87: var command =
parser.addCommand('cmd', new ArgParser(allowTrailingOptions: false));
long line

[Bob Nystrom, 2014-05-05 22:36:02]

Hey, if you're on this review, it's because I tweaked the pubspec of a package
that I think you maintain.

All I'm doing is widening the args version constraint (and bumping the version
of your package). This is because I'm making a theoretically breaking change to
args that does not in fact break your package. Since your package works with
both the new and old args, I'm widening your constraint to reflect that fact.

PTAL and let me know if the change is OK.

Thanks!

https://codereview.chromium.org/260963007/diff/1/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/1/pkg/analyzer/pubspec.yaml#ne...
pkg/analyzer/pubspec.yaml:9: args: '>=0.10.0 <0.12.0'
On 2014/05/05 19:52:45, nweiz wrote:
> You should bump the build versions of any non-dev packages whose dependencies
> you're changing, and CC the owners on this CL.

Done.

https://codereview.chromium.org/260963007/diff/1/pkg/args/CHANGELOG.md
File pkg/args/CHANGELOG.md (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/CHANGELOG.md#newcode5
pkg/args/CHANGELOG.md:5: trailing options.
On 2014/05/05 19:52:45, nweiz wrote:
> What's with all the whitespace between the * and the text?

It's not really necessary here but it means that subsequent paragraphs under the
same bullet points would line up. Changed it back.

https://codereview.chromium.org/260963007/diff/1/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/pubspec.yaml#newcode13
pkg/args/pubspec.yaml:13: unittest: ">=0.9.0 <0.10.0"
On 2014/05/02 03:05:48, kevmoo wrote:
> While you're at it: update this to <0.11.0

Done.

https://codereview.chromium.org/260963007/diff/1/pkg/args/test/trailing_optio...
File pkg/args/test/trailing_options_test.dart (right):

https://codereview.chromium.org/260963007/diff/1/pkg/args/test/trailing_optio...
pkg/args/test/trailing_options_test.dart:87: var command =
parser.addCommand('cmd', new ArgParser(allowTrailingOptions: false));
On 2014/05/05 19:52:45, nweiz wrote:
> long line

Done.

[Jennifer Messerly, 2014-05-05 22:40:14]

polymer changes -> lgtm

[nweiz, 2014-05-05 22:46:11]

https://codereview.chromium.org/260963007/diff/20001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/20001/pkg/analyzer/pubspec.yam...
pkg/analyzer/pubspec.yaml:2: version: 0.15.2-dev
I'd just make this 0.15.1+1 and release it, assuming you get the go-ahead from
the analyzer folks. Same with other pubspecs.

[Bob Nystrom, 2014-05-05 23:06:03]

https://codereview.chromium.org/260963007/diff/20001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/260963007/diff/20001/pkg/analyzer/pubspec.yam...
pkg/analyzer/pubspec.yaml:2: version: 0.15.2-dev
On 2014/05/05 22:46:12, nweiz wrote:
> I'd just make this 0.15.1+1 and release it, assuming you get the go-ahead from
> the analyzer folks. Same with other pubspecs.

I'd rather let their respective owners publish when they want they want to.

[Brian Wilkerson, 2014-05-06 20:27:48]

Analyzer changes LGTM

[Bob Nystrom, 2014-05-06 23:26:07]

Committed patchset #2 manually as r35837 (presubmit successful).