Remove PhaseInput and add TransformerSorter to barback.

Remove PhaseInput and add TransformerSorter to barback.

Aggregate transformers aren't yet supported, but this introduces the
large-scale structure necessary to support them.

R=rnystrom@google.com
BUG=18567
Committed: https://code.google.com/p/dart/source/detail?r=35676

[Bob Nystrom, 2014-05-01 19:49:33]

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
File pkg/barback/lib/src/transformer_sorter.dart (right):

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:21: /// `sortPrimary` method.
This doesn't exist yet, right?

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:26: class TransformerSorter {
"Sorter" isn't the right word here since it implies ordering when really this is
just about partitioning.

How about PhaseTransformer? That clarifies that it's a transformer as it exists
within some phase, and parallels PhaseForwarder.

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:89: var transform = new
TransformNode(_phase, transformer, input, _location);
Long line.

[nweiz, 2014-05-01 20:47:01]

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
File pkg/barback/lib/src/transformer_sorter.dart (right):

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:21: /// `sortPrimary` method.
On 2014/05/01 19:49:33, Bob Nystrom wrote:
> This doesn't exist yet, right?

Correct.

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:26: class TransformerSorter {
On 2014/05/01 19:49:33, Bob Nystrom wrote:
> "Sorter" isn't the right word here since it implies ordering when really this
is
> just about partitioning.

It's sorting in the commonly-used real-world sense, but I take your point that
it's different than the usual computer science sense. The computer science name
for this would be "shuffler", to match the MapReduce terminology, but I thought
"Transformer.sortPrimary" was clearer than "Transformer.shufflePrimary", and
once that name was in place "sorter" seemed natural here.

> How about PhaseTransformer? That clarifies that it's a transformer as it
exists
> within some phase, and parallels PhaseForwarder.

That's really overloading the meaning of "transformer", which already has a lot
of semantic baggage in barback. This certainly isn't a transformer, nor is it
really a transform since it manages multiple transforms.

https://codereview.chromium.org/260833006/diff/1/pkg/barback/lib/src/transfor...
pkg/barback/lib/src/transformer_sorter.dart:89: var transform = new
TransformNode(_phase, transformer, input, _location);
On 2014/05/01 19:49:33, Bob Nystrom wrote:
> Long line.

Done.

[Bob Nystrom, 2014-05-02 00:42:04]

lgtm

https://codereview.chromium.org/260833006/diff/40001/pkg/barback/lib/src/tran...
File pkg/barback/lib/src/transformer_classifier.dart (right):

https://codereview.chromium.org/260833006/diff/40001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transformer_classifier.dart:23: /// This is used for
non-aggregate transformers; they're modeled as aggregate
"modelled".

[nweiz, 2014-05-02 01:21:14]

https://codereview.chromium.org/260833006/diff/40001/pkg/barback/lib/src/tran...
File pkg/barback/lib/src/transformer_classifier.dart (right):

https://codereview.chromium.org/260833006/diff/40001/pkg/barback/lib/src/tran...
pkg/barback/lib/src/transformer_classifier.dart:23: /// This is used for
non-aggregate transformers; they're modeled as aggregate
On 2014/05/02 00:42:04, Bob Nystrom wrote:
> "modelled".

According to Wiktionary, "modelled" is UK and "modeled" is US.

[nweiz, 2014-05-02 01:25:21]

Committed patchset #3 manually as r35676 (presubmit successful).