Rewrite Class::HasTypeArguments() for efficiency.

Rewrite Class::HasTypeArguments() for efficiency.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28319

[siva, 2013-10-07 04:06:37]

lgtm

https://codereview.chromium.org/26072002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/26072002/diff/1/runtime/vm/object.cc#newcode1746
runtime/vm/object.cc:1746: bool Class::HasTypeArguments() const {
Would it make sense to have a fast check first:
if (!isSignature......) {
  return ...;
} else {
  return (NumTypePa......);
}
Isolate* isolate = Isolate::Cu...
Class& cls = Class::Handle(isolate, raw());
do {
  if ((cls.super_type() != AbstractType::null()) &&
       (cls.super_type != isolate....)) {
    ...
    return false;
  }
  cls.SuperClass();
  ....
  ....
}

[regis, 2013-10-07 18:28:06]

Thanks!

https://codereview.chromium.org/26072002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/26072002/diff/1/runtime/vm/object.cc#newcode1746
runtime/vm/object.cc:1746: bool Class::HasTypeArguments() const {
On 2013/10/07 04:06:37, siva wrote:
> Would it make sense to have a fast check first:
> if (!isSignature......) {
>   return ...;
> } else {
>   return (NumTypePa......);
> }
> Isolate* isolate = Isolate::Cu...
> Class& cls = Class::Handle(isolate, raw());
> do {
>   if ((cls.super_type() != AbstractType::null()) &&
>        (cls.super_type != isolate....)) {
>     ...
>     return false;
>   }
>   cls.SuperClass();
>   ....
>   ....
> }

Done.

[regis, 2013-10-07 18:38:33]

Committed patchset #2 manually as r28319 (presubmit successful).