Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 26057002: Fix the names of some tests. (Closed)

Created:
7 years, 2 months ago by Bob Nystrom
Modified:
7 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the names of some tests. A couple of tests didn't end in "_test", so weren't being run. Turns out that masked a bug! Oops. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=28291

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Bob Nystrom
7 years, 2 months ago (2013-10-04 22:55:38 UTC) #1
nweiz
lgtm I feel like this would be easier to avoid if we didn't name test ...
7 years, 2 months ago (2013-10-04 23:02:44 UTC) #2
Bob Nystrom
Committed patchset #1 manually as r28291 (presubmit successful).
7 years, 2 months ago (2013-10-04 23:21:29 UTC) #3
Bob Nystrom
7 years, 2 months ago (2013-10-04 23:23:40 UTC) #4
Message was sent while issue was closed.
On 2013/10/04 23:02:44, nweiz wrote:
> lgtm
> 
> I feel like this would be easier to avoid if we didn't name test files in
> complete sentences -- that is, if we allowed files to contain multiple tests.
> :-|

Yeah. I'm up for doing some test file consolidation. I do want to make sure
that:

1. Any given test file runs pretty quickly. Our tests tend to be way slower than
the average unit test.
2. Any given test file isn't very long. Each of our tests tends to be pretty
big, and I hate wading through huge test suites.
3. We have some easy way of running a single test in isolation. solo_test works,
but it's a bit of a chore.

In the future, I think we'll probably have a new test system that's more
mirror-based with a dedicated test runner. When we do, we can revisit a lot of
this.

Powered by Google App Engine
This is Rietveld 408576698