Issue 260233003: Remove js.Sequence and use binary comma operator instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260233003: Remove js.Sequence and use binary comma operator instead. (Closed)

Created:
6 years, 7 months ago by sra1

Modified:
6 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove js.Sequence and use binary comma operator instead. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=35879

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -51 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	5 chunks	+4 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/printer.dart	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/template.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	2 chunks	+25 lines, -21 lines	0 comments	Download
M	tests/compiler/dart2js/js_parser_statements_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

sra1

We have both a binary comma-operator and a sequence, so we should remove one. I ...

6 years, 7 months ago (2014-04-29 02:52:29 UTC) #1

sra1

6 years, 7 months ago (2014-05-08 03:41:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35879 (presubmit successful).