Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 26023005: It is not an error anymore to leave an instance final field uninitialized. (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

It is not an error anymore to leave an instance final field uninitialized. Fix issues 11054 and 12157. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/constructor9_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 2 months ago (2013-10-04 22:06:43 UTC) #1
srdjan
lgtm
7 years, 2 months ago (2013-10-04 22:51:56 UTC) #2
regis
7 years, 2 months ago (2013-10-04 22:56:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698