dart:io | Add FileSystemEntity.parent, make File.directory call it.

dart:io | Add FileSystemEntity.parent, make File.directory call it.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28986

[Søren Gjesse, 2013-10-04 12:20:15]

Shouldn't there be some tests for Directory and Link?

Deprecate File.directory?

https://codereview.chromium.org/26001002/diff/5001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/26001002/diff/5001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:537: Directory get parent {
How about

return new Directory(new Uri.file(path).resolve('..').toFilePath());

[Bill Hesse, 2013-10-04 12:41:05]

Deprecated File.directory.

https://codereview.chromium.org/26001002/diff/5001/sdk/lib/io/file_system_ent...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/26001002/diff/5001/sdk/lib/io/file_system_ent...
sdk/lib/io/file_system_entity.dart:537: Directory get parent {
On 2013/10/04 12:20:16, Søren Gjesse wrote:
> How about
> 
> return new Directory(new Uri.file(path).resolve('..').toFilePath());
> 

This will not give the desired result, since it will remove all '..' and '.'
segments, and it will do different things depending on whether there are
trailing slashes.

[Bill Hesse, 2013-10-04 12:49:24]

Issue 13828 filed (https://code.google.com/p/dart/issues/detail?id=13828) for
adding tests to Directory and Link.

[Bill Hesse, 2013-10-22 07:03:22]

Tests added, code improved.  PTAL.

[Søren Gjesse, 2013-10-22 07:12:07]

lgtm

[Bill Hesse, 2013-10-22 07:32:14]

Committed patchset #6 manually as r28986 (presubmit successful).