Issue 25996006: Add test coverage for InstanceMirror.type in the face of a reflectee that overrides runtimeType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25996006: Add test coverage for InstanceMirror.type in the face of a reflectee that overrides runtimeType. (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
ahe, gbracha, srdjan

CC:
reviews_dartlang.org, zarah, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test coverage for InstanceMirror.type in the face of a reflectee that overrides runtimeType. R=gbracha@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28311

Patch Set 5 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/lib/mirrors/proxy_type_test.dart	View	1 2 3	1 chunk	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gbracha

lgtm with minor comment https://codereview.chromium.org/25996006/diff/4001/tests/lib/mirrors/proxy_type_test.dart File tests/lib/mirrors/proxy_type_test.dart (right): https://codereview.chromium.org/25996006/diff/4001/tests/lib/mirrors/proxy_type_test.dart#newcode11 tests/lib/mirrors/proxy_type_test.dart:11: // instanceMirror.type in the face ...

7 years, 2 months ago (2013-10-05 01:12:54 UTC) #3

rmacnak

7 years, 2 months ago (2013-10-07 16:38:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r28311 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25996006: Add test coverage for InstanceMirror.type in the face of a reflectee that overrides runtimeType. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : mispelling #

Patch Set 4 : #

Patch Set 5 : #

Messages