Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 259773004: Generate dart:blink in the SDK (Closed)

Created:
6 years, 8 months ago by Leaf
Modified:
6 years, 8 months ago
Reviewers:
vsm, Ivan Posva
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Generate dart:blink in the SDK BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=35439

Patch Set 1 #

Patch Set 2 : Adding dart:blink to SDK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11357 lines, -3789 lines) Patch
A sdk/lib/blink/dartium/blink_dartium.dart View 1 1 chunk +7529 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 528 chunks +2604 lines, -2581 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 14 chunks +86 lines, -85 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 114 chunks +722 lines, -720 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 35 chunks +182 lines, -181 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 15 chunks +194 lines, -193 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 8 chunks +16 lines, -14 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 6 chunks +12 lines, -4 lines 0 comments Download
M tools/dom/scripts/go.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 7 chunks +8 lines, -9 lines 0 comments Download
M tools/dom/templates/html/dartium/chrome_dartium.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Leaf
6 years, 8 months ago (2014-04-25 17:59:46 UTC) #1
vsm
lgtm
6 years, 8 months ago (2014-04-25 18:14:15 UTC) #2
Leaf
Committed patchset #2 manually as r35439 (presubmit successful).
6 years, 8 months ago (2014-04-25 18:29:13 UTC) #3
Leaf
6 years, 8 months ago (2014-04-25 20:06:07 UTC) #4
Message was sent while issue was closed.
Reverting patch

Powered by Google App Engine
This is Rietveld 408576698