fix list filtering if the filter is a method

fix list filtering if the filter is a method
https://code.google.com/p/dart/issues/detail?id=13459

R=justinfagnani@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28345

[Jennifer Messerly, 2013-10-04 02:18:18]

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:151: class Scope {
trivial style fix: remove "extends Object" which is implied.

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:604: Object call(Object receiver, List
args) {
trivial style fix: avoid "dynamic" except as type parameter.
factor out the _convert

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:638: call(arg0) => mirror.invoke(symbol,
[arg0], null).reflectee;
the actual bug fix. "call" is different from Function.apply; it's expected to
match the method signature.

[justinfagnani, 2013-10-04 20:41:46]

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:638: call(arg0) => mirror.invoke(symbol,
[arg0], null).reflectee;
On 2013/10/04 02:18:19, John Messerly wrote:
> the actual bug fix. "call" is different from Function.apply; it's expected to
> match the method signature.

I think this fix could be different, because InstanceMirror.getField() is
supposed to correctly closurize methods now.

Background on Method: I think that this call() originally wasn't intended to be
the Function-emulating call(), but was used to invoke the method from within
polymer expression code consistently where there used to be a FunctionWrapper
class. Unfortunate naming, that's why the signature took a list.

Right now the invoke ast node takes care of invoking most methods, and only
those that are method directly on the model object get wrapped in Method. Other
methods reached via expressions won't be wrapped, but should be closurized by
mirrors. I think we might just want to remove call() altogether.

[Jennifer Messerly, 2013-10-04 20:44:28]

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:638: call(arg0) => mirror.invoke(symbol,
[arg0], null).reflectee;
Alright, I'll take a shot at removing "Method" instead. Fingers crossed it
actually works in all impls now.

[justinfagnani, 2013-10-04 20:46:08]

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:175: var memberMirror =
getMemberMirror(classMirror, symbol);
We should be able to reduce the follow if/else to:

if (memberMirror != null) {
  return _convert(_modelMirror.getField(symbol).reflectee);
}

https://codereview.chromium.org/25967002/diff/1/pkg/polymer_expressions/lib/e...
pkg/polymer_expressions/lib/eval.dart:604: Object call(Object receiver, List
args) {
if InstanceMirror.getField() properly closurizes, we can replace call() with
Function.apply()

[Jennifer Messerly, 2013-10-04 22:39:00]

hey Justin, I tried this, but it seems to be not working in dart2js yet. What
should we do?

[justinfagnani, 2013-10-05 03:53:09]

On 2013/10/04 22:39:00, John Messerly wrote:
> hey Justin, I tried this, but it seems to be not working in dart2js yet. What
> should we do?

Darn:
https://code.google.com/p/dart/issues/detail?id=13002

well, this patch fixes the method as filter case, so we can go with that and a
TODO to update when 13002 is fixed.

[Jennifer Messerly, 2013-10-07 07:06:42]

On 2013/10/05 03:53:09, justinfagnani wrote:
> On 2013/10/04 22:39:00, John Messerly wrote:
> > hey Justin, I tried this, but it seems to be not working in dart2js yet.
What
> > should we do?
> 
> Darn:
> https://code.google.com/p/dart/issues/detail?id=13002
> 
> well, this patch fixes the method as filter case, so we can go with that and a
> TODO to update when 13002 is fixed.

Sounds good. If I add a TODO does it look good otherwise? :)

[justinfagnani, 2013-10-07 16:57:58]

lgtm

[Jennifer Messerly, 2013-10-08 00:35:24]

Committed patchset #2 manually as r28345 (presubmit successful).