Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 25958003: Disable co19 on none-drt (Closed)

Created:
7 years, 2 months ago by kustermann
Modified:
7 years, 2 months ago
Reviewers:
ricow1, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable co19 on none-drt Note that we currently don't run co19 on content_shell because co19 repsoitory is not in dartium.deps/DEPS. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28256

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/co19/co19-dartium.status View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
7 years, 2 months ago (2013-10-04 09:32:59 UTC) #1
kasperl
LGTM.
7 years, 2 months ago (2013-10-04 09:35:03 UTC) #2
kustermann
Committed patchset #1 manually as r28256 (presubmit successful).
7 years, 2 months ago (2013-10-04 09:40:14 UTC) #3
ricow1
LGTM https://codereview.chromium.org/25958003/diff/1/tests/co19/co19-dartium.status File tests/co19/co19-dartium.status (right): https://codereview.chromium.org/25958003/diff/1/tests/co19/co19-dartium.status#newcode6 tests/co19/co19-dartium.status:6: *: Skip # running co19 tests on content_shell ...
7 years, 2 months ago (2013-10-04 09:51:21 UTC) #4
kustermann
On 2013/10/04 09:51:21, ricow1 wrote: > LGTM > > https://codereview.chromium.org/25958003/diff/1/tests/co19/co19-dartium.status > File tests/co19/co19-dartium.status (right): > ...
7 years, 2 months ago (2013-10-04 09:53:05 UTC) #5
ricow1
7 years, 2 months ago (2013-10-04 10:06:22 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/25958003/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/25958003/diff/1/tests/co19/co19-dartium.statu...
tests/co19/co19-dartium.status:6: *: Skip # running co19 tests on content_shell
would make our dartium cycle-times very long
On 2013/10/04 09:51:21, ricow1 wrote:
> I guess we can run them if we get incremental building going again
I misread, this is just drt, so we are running it on dartium so we have full
coverage, thx

Powered by Google App Engine
This is Rietveld 408576698