- Harden coverage generation, by not attempting to compile

- Harden coverage generation, by not attempting to compile
  un-compilable functions.
- Only register closure functions in the class when they
  have been properly setup.
- Make sure to compile closure functions when calling CompileAll.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28282

[hausner, 2013-10-04 16:06:22]

LGTM with comments

https://codereview.chromium.org/25954003/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/25954003/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:883: !func.IsRedirectingFactory()) {
Can we really have abstract functions or redirecting factories in the closure
list? I would not expect that. Maybe assert instead?

https://codereview.chromium.org/25954003/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/25954003/diff/1/runtime/vm/coverage.cc#newcode33
runtime/vm/coverage.cc:33: // before we have compiled its enclosing function.
Or the enclosing function failed to compile.

[Ivan Posva, 2013-10-04 20:50:02]

https://codereview.chromium.org/25954003/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/25954003/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:883: !func.IsRedirectingFactory()) {
On 2013/10/04 16:06:23, hausner wrote:
> Can we really have abstract functions or redirecting factories in the closure
> list? I would not expect that. Maybe assert instead?

Copy & Pasterr.

https://codereview.chromium.org/25954003/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/25954003/diff/1/runtime/vm/coverage.cc#newcode33
runtime/vm/coverage.cc:33: // before we have compiled its enclosing function.
On 2013/10/04 16:06:23, hausner wrote:
> Or the enclosing function failed to compile.

Done.

[Ivan Posva, 2013-10-04 20:50:21]

Committed patchset #2 manually as r28282 (presubmit successful).