More mirror tests: initializing formals and substituted types in instantiated generics.

More mirror tests: initializing formals and substituted types in instantiated generics.

BUG=
R=gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28271

[gbracha, 2013-10-03 23:20:00]

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
File tests/lib/mirrors/generics_substitution_test.dart (right):

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
tests/lib/mirrors/generics_substitution_test.dart:37: Expect.equals(#S,
s(genericDecl.superclass));
These two are wrong. The first is T, the second is int

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
tests/lib/mirrors/generics_substitution_test.dart:42: Expect.equals(#T,
t(genericOfString));
Should be string

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
File tests/lib/mirrors/initializing_formals_test.dart (right):

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
tests/lib/mirrors/initializing_formals_test.dart:15: dynamic _privateField;
Any reason for using dynamic rather than var? This is generally bad style

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
tests/lib/mirrors/initializing_formals_test.dart:92: Expect.isTrue(pm.isFinal); 
/// 01: ok
Hm, this seems a bit speculative.

[rmacnak, 2013-10-04 01:17:36]

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
File tests/lib/mirrors/generics_substitution_test.dart (right):

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
tests/lib/mirrors/generics_substitution_test.dart:37: Expect.equals(#S,
s(genericDecl.superclass));
On 2013/10/03 23:20:01, gbracha wrote:
> These two are wrong. The first is T, the second is int

Done.

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/generics...
tests/lib/mirrors/generics_substitution_test.dart:42: Expect.equals(#T,
t(genericOfString));
On 2013/10/03 23:20:01, gbracha wrote:
> Should be string
Done.

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
File tests/lib/mirrors/initializing_formals_test.dart (right):

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
tests/lib/mirrors/initializing_formals_test.dart:15: dynamic _privateField;
On 2013/10/03 23:20:01, gbracha wrote:
> Any reason for using dynamic rather than var? This is generally bad style

Just being systematic with explicit types.

https://codereview.chromium.org/25945002/diff/3001/tests/lib/mirrors/initiali...
tests/lib/mirrors/initializing_formals_test.dart:92: Expect.isTrue(pm.isFinal); 
/// 01: ok
On 2013/10/03 23:20:01, gbracha wrote:
> Hm, this seems a bit speculative.

Fixed and added case where it really is final.

[gbracha, 2013-10-04 01:21:50]

lgtm

[rmacnak, 2013-10-04 17:41:57]

Committed patchset #4 manually as r28271 (presubmit successful).