Issue 259393002: Enums cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259393002: Enums cleanup. (Closed)

Created:
6 years, 7 months ago by regis

Modified:
6 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -71 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1	5 chunks	+12 lines, -12 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+15 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	4 chunks	+9 lines, -11 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

regis

Replacing all bit positions by arithmetic expressions makes it difficult to consult the enum and ...

6 years, 7 months ago (2014-04-29 19:39:09 UTC) #1

regis

6 years, 7 months ago (2014-04-30 01:26:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35559 (presubmit successful).