Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 259093004: Allow a NumberFormat to be passed a currency name/symbol at creation (Closed)

Created:
6 years, 7 months ago by Alan Knight
Modified:
6 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow a NumberFormat to be passed a currency name/symbol at creation BUG=https://code.google.com/p/dart/issues/detail?id=18499 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=35496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
M pkg/intl/lib/number_format.dart View 5 chunks +20 lines, -8 lines 0 comments Download
M pkg/intl/test/number_format_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
6 years, 7 months ago (2014-04-28 20:26:35 UTC) #1
Emily Fortuna
lgtm
6 years, 7 months ago (2014-04-28 20:38:32 UTC) #2
Alan Knight
6 years, 7 months ago (2014-04-28 20:46:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698