Don't evaluate the argument twice for unresolved static setter calls.

Don't evaluate the argument twice for unresolved static setter calls.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28253

[Florian Schneider, 2013-10-03 14:13:54]

dbc:

https://codereview.chromium.org/25877002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (left):

https://codereview.chromium.org/25877002/diff/1/tests/co19/co19-co19.status#o...
tests/co19/co19-co19.status:26: Language/12_Expressions/18_Assignment_A01_t07:
RuntimeError # co19-roll r607: Please triage this failure
VM is not fixed yet. I have a fix coming up soon. In the meantime, move it to
the co19-runtime status file.

[kasperl, 2013-10-04 07:30:27]

LGTM!

https://codereview.chromium.org/25877002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/25877002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2722: argumentValues:
(send == null ? <HInstruction>[] :
I'd compute the argument values outside the call to generateThrowNoSuchMethod
and stuff it in a local (to avoid some of the nesting). Could the empty list be
const?

[karlklose, 2013-10-04 08:46:55]

Thanks, Kasper and Florian.

https://codereview.chromium.org/25877002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (left):

https://codereview.chromium.org/25877002/diff/1/tests/co19/co19-co19.status#o...
tests/co19/co19-co19.status:26: Language/12_Expressions/18_Assignment_A01_t07:
RuntimeError # co19-roll r607: Please triage this failure
On 2013/10/03 14:13:54, Florian Schneider wrote:
> VM is not fixed yet. I have a fix coming up soon. In the meantime, move it to
> the co19-runtime status file.

Done.

https://codereview.chromium.org/25877002/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/25877002/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2722: argumentValues:
(send == null ? <HInstruction>[] :
On 2013/10/04 07:30:27, kasperl wrote:
> I'd compute the argument values outside the call to generateThrowNoSuchMethod
> and stuff it in a local (to avoid some of the nesting). Could the empty list
be
> const?

Done.

[karlklose, 2013-10-04 08:47:17]

Committed patchset #3 manually as r28253 (presubmit successful).