Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 25864002: Update handling of exports. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update handling of exports. BUG=http://dartbug.com/13750 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=28214

Patch Set 1 #

Patch Set 2 : Change message order. #

Patch Set 3 : Update status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -35 lines) Patch
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 10 chunks +76 lines, -30 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +18 lines, -3 lines 0 comments Download
A + tests/language/duplicate_export_liba.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language/duplicate_export_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-10-03 11:28:23 UTC) #1
ahe
LGTM!
7 years, 2 months ago (2013-10-03 12:21:00 UTC) #2
Johnni Winther
7 years, 2 months ago (2013-10-03 12:48:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698