Add a Cascade helper to Shelf.

Add a Cascade helper to Shelf.

R=kevmoo@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35437

[kevmoo, 2014-04-25 00:32:31]

Ponder the const ctor case?

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.dart
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.da...
pkg/shelf/lib/src/cascade.dart:22: ///     var handler = const Cascade()
Where's the const ctor?

[nweiz, 2014-04-25 00:54:56]

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.dart
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.da...
pkg/shelf/lib/src/cascade.dart:22: ///     var handler = const Cascade()
On 2014/04/25 00:32:31, kevmoo wrote:
> Where's the const ctor?

Just a documentation error, this should be "new". "const" won't work because it
can take a callback.

[kevmoo, 2014-04-25 13:26:04]

LGTM

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.dart
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/1/pkg/shelf/lib/src/cascade.da...
pkg/shelf/lib/src/cascade.dart:22: ///     var handler = const Cascade()
On 2014/04/25 00:54:56, nweiz wrote:
> On 2014/04/25 00:32:31, kevmoo wrote:
> > Where's the const ctor?
> 
> Just a documentation error, this should be "new". "const" won't work because
it
> can take a callback.

Actually, taking in a callback is fine. Having a body is the issue.

https://codereview.chromium.org/258633006/diff/20001/pkg/shelf/lib/src/cascad...
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/20001/pkg/shelf/lib/src/cascad...
pkg/shelf/lib/src/cascade.dart:30: final Function _shouldCascade;
I'm a fan of defining the private typedef for these cases. Improves readability
and makes it less likely a future dev will break something.

[nweiz, 2014-04-25 18:23:34]

https://codereview.chromium.org/258633006/diff/20001/pkg/shelf/lib/src/cascad...
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/20001/pkg/shelf/lib/src/cascad...
pkg/shelf/lib/src/cascade.dart:30: final Function _shouldCascade;
On 2014/04/25 13:26:05, kevmoo wrote:
> I'm a fan of defining the private typedef for these cases. Improves
readability
> and makes it less likely a future dev will break something.

Done.

[nweiz, 2014-04-25 18:24:36]

Committed patchset #3 manually as r35437 (presubmit successful).

[kevmoo, 2014-04-25 21:55:10]

:-)

https://codereview.chromium.org/258633006/diff/40001/pkg/shelf/lib/src/cascad...
File pkg/shelf/lib/src/cascade.dart (right):

https://codereview.chromium.org/258633006/diff/40001/pkg/shelf/lib/src/cascad...
pkg/shelf/lib/src/cascade.dart:84: Function _computeShouldCascade(Iterable<int>
statusCodes,
Woulda coulda used typedef here, too :-)